dwc_eqos - fix transmitted vlan tags #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All transmitted VLAN tags were 0. We weren't setting the VlanInput flag, so when inserting VLAN tags, the adapter was using a global value (0) instead of the value from the descriptor ring. Fix. - Set the VlanInput flag so that inserted VLAN tags are taken from context descriptor. - Add a VLAN ID configuration setting. This is a semi-standard tag, and I couldn't find great details on how it is supposed to work. At present, it just controls the default VLAN tag to use when transmitting. I think some adapters also use it to filter received packets, but I don't think that's a good idea for this driver since NetAdapterCx doesn't support OID_GEN_VLAN_ID. - Update Tx path to handle a default VLAN tag. Ended up cleaning things up a bit so the result is shorter.
mariobalanica
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All transmitted VLAN tags were 0. We weren't setting the VlanInput flag, so when inserting VLAN tags, the adapter was using a global value (0) instead of the value from the descriptor ring. Fix.