dwc_eqos - segmentation offload and vlan fixes #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
idigdoug
commented
Jan 17, 2024
•
idigdoug
commented
- Add a README.md.
- Add a REG file for enabling a diagnostic ETW autologger.
- Implement TCP segmentation offload (LSOv2).
- Implement UDP fragmentation offload (USO).
- Instead of making a half-baked effort to adapt to disabled hardware features (i.e. lack of Checksum or Segment offload support), check for the feature and don't load if it's missing. At present, I have nothing to test this on and it just makes the code messy. We can add adaptability back in the future if anybody actually wants it and has hardware to test it.
- Fix problems with error logging in Tx path (error bit is only valid for LastDescriptor).
- Fix problems with VLAN tag insertion.
- Fix problems with checksum offload configuration. NetAdapterCx only recognizes the "granular" options.
mariobalanica
approved these changes
Jan 17, 2024
- Add a README.md. - Add a REG file for enabling a diagnostic ETW autologger. - Implement TCP segmentation offload (LSOv2). - Implement UDP fragmentation offload. (USO). - Instead of making a half-baked effort to adapt to disabled hardware features (i.e. lack of Checksum or Segment offload support), check for the feature and don't load if it's missing. At present, I have nothing to test this on and it just makes the code messy. We can add adaptability back in the future if anybody actually wants it and has hardware to test it. - Fix problems with error logging in Tx path. - Fix problems with VLAN tag insertion. - Fix problems with checksum offload configuration. NetAdapterCx only recognizes the "granular" options.
idigdoug
force-pushed
the
dwc_eqos_gso
branch
from
b16b98c to
39adee2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.