dwc_eqos - vlan, flow, INF config options #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change checksum offload INF options from granular to combined. - Add INF options for FlowControl, PriorityVlanTag. - Respect INF option for FlowControl at MAC level. - Set DisableReceiveOwn on MAC options. - Correct Rx VLAN tag behavior: always strip tag, always copy tag to OOB. - Correct Tx VLAN tag behavior: add tag if present in OOB. - Stop tracking Tx-Own statistics. They don't seem useful. The Tx VLAN tag behavior required significant refactoring of TxQueueAdvance. Previously we depended on one-to-one mapping between descriptor and fragment, but VLAN tags require context descriptors so there can now be descriptors without a matching fragment, so our descriptor drain code needs to deal with that.
coolstar
approved these changes
Jan 5, 2024
mariobalanica
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Tx VLAN tag behavior required significant refactoring of TxQueueAdvance. Previously we depended on one-to-one mapping between descriptor and fragment, but VLAN tags require context descriptors so there can now be descriptors without a matching fragment, so our descriptor drain code needs to deal with that.