Add i2c and gpio driver #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariobalanica
requested changes
Oct 31, 2023
There was a problem hiding this comment.
Nice work!
A couple of reviews:
-
Please move the drivers into their own subdirectories.
-
Include
\build\common.propsin the project files and add them to the solution. -
rk3xi2c package project and solution are unnecessary.
-
rk3xi2c.infhas messed up encoding? Should also be.inx. -
Rename the device descriptions to "Rockchip I2C Controller" and "Rockchip GPIO Controller" to be consistent with existing naming. Manufacturer should also be "Rockchip", this is different from the driver provider.
coolstar
force-pushed
the
master
branch
2 times, most recently
from
92601a7 to
a7582a2
Compare
mariobalanica
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on Orange Pi 5 by writing + reading to RTC