gmac - fix hang in Ethernet driver #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ethernet driver is hanging. Occurs due to rollover of statistics, which triggers an interrupt, and we never clear the interrupt's status. Quick fix is to just freeze the statistics, and then they never trigger interrupts. Additional change: disable interrupts while the DPC is pending. This noticably improves performance.
coolstar
approved these changes
Dec 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ethernet driver is hanging. Occurs due to rollover of statistics, which triggers an interrupt, and we never clear the interrupt's status.
Quick fix is to just freeze the statistics, and then they never trigger interrupts.
Additional change: disable interrupts while the DPC is pending. This noticably improves performance.