solana: Validation of the new spl metadata account #4132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Attestation is failing for tokens that were created recently. Cause: Metaplex has resized the SPL token metadata account from 679 bytes to 607 bytes in the commit (6b2e869) However, the token-bridge is still using the older version of the SPL token metadata and validating the size based on the older constant. As a result, this check fails to attest tokens that are using the new metadata accounts. Solution: To resolve this, I have added an additional condition with the new metadata length constant, allowing the validation to pass if the SPL token has either of the two metadata account lengths.
|
Hi team any news @kcsongor @a5-pickle @johnsaigle |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Attestation is failing for tokens that were created recently.
Cause: Metaplex has resized the SPL token metadata account from 679 bytes to 607 bytes in the commit (6b2e869) However, the token-bridge is still using the older version of the SPL token metadata and validating the size based on the older constant. As a result, this check fails to attest tokens that are using the new metadata accounts.
Solution: To resolve this, I have added an additional condition with the new metadata length constant, allowing the validation to pass if the SPL token has either of the two metadata account lengths.