Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Martinh/sdk layout #125

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Martinh/sdk layout #125

wants to merge 15 commits into from

Conversation

martin0995
Copy link
Collaborator

Description

Created a Wormhole SDK Layout page.

Checklist

  • Required - I have added a label to this PR 🏷️
  • Required - I have run my changes through Grammarly
  • If pages have been moved, I have created redirects in the wormhole-mkdocs repo

@martin0995 martin0995 added the A0 - New Content Pull request contains new content pages label Oct 23, 2024
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! The content is explained well. I did a quick search for minor formatting stuff, but I did not yet run grammarly, so if you haven't already, please make sure you do this!

I might propose a slightly different structure for the page, so you first cover all the essentials, then cover the nice to haves:

  • Introduction
  • Key Concepts
  • Application of Layouts
  • Nested Layouts and Strong Typing
  • Commonly Used Layouts
  • Advanced Use Cases
  • Integration with Wormhole
  • Common Pitfalls & Best Practices
  • Performance Considerations

wdyt?

build/toolkit/.pages Show resolved Hide resolved
build/toolkit/wormhole-sdk/.pages Outdated Show resolved Hide resolved
build/toolkit/wormhole-sdk/sdk-layout.md Outdated Show resolved Hide resolved
build/toolkit/wormhole-sdk/.pages Outdated Show resolved Hide resolved
build/toolkit/wormhole-sdk/sdk-layout.md Outdated Show resolved Hide resolved
build/toolkit/wormhole-sdk/sdk-layout.md Outdated Show resolved Hide resolved
build/toolkit/wormhole-sdk/sdk-layout.md Outdated Show resolved Hide resolved
build/toolkit/wormhole-sdk/sdk-layout.md Outdated Show resolved Hide resolved
build/toolkit/wormhole-sdk/sdk-layout.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0 - New Content Pull request contains new content pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants