Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: use SDK amount.Amount type to store token amounts #2868

Open
wants to merge 7 commits into
base: development
Choose a base branch
from

Conversation

artursapek
Copy link
Collaborator

@artursapek artursapek commented Oct 21, 2024

Changes

  • Change Balance type, and amount values in Redux, to store an amount.Amount, not a number
  • Update validation code accordingly
  • Remove formatting hacks (removing commas, etc)
  • Remove formatAmount helper function (not required anymore)
  • Remove dead code in SDKv2 adapter

Overall cleans things up and net removal of code

Copy link

netlify bot commented Oct 21, 2024

Deploy Preview for wormhole-connect ready!

Name Link
🔨 Latest commit 0adb5b5
🔍 Latest deploy log https://app.netlify.com/sites/wormhole-connect/deploys/6716ccdf83e25c0008d6cbd4
😎 Deploy Preview https://deploy-preview-2868--wormhole-connect.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 21, 2024

👷 Deploy request for wormhole-connect-mainnet pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 0adb5b5

@artursapek artursapek marked this pull request as draft October 21, 2024 17:13
@artursapek artursapek marked this pull request as ready for review October 21, 2024 21:51
@artursapek artursapek changed the title Refactor: use SDK amount.Amount type to store balances Refactor: use SDK amount.Amount type to store token amounts Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant