-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solana: add recovery flow #418
Draft
kcsongor
wants to merge
9
commits into
main
Choose a base branch
from
solana/recovery
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Commits on Apr 17, 2024
-
solana: pass token_program to ATA (support token22)
The associated token program instructions default to the legacy SPL token program. We pass the token_program as an argument to support token2022 tokens too.
Configuration menu - View commit details
-
Copy full SHA for b312d0d - Browse repository at this point
Copy the full SHA b312d0dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 508af61 - Browse repository at this point
Copy the full SHA 508af61View commit details -
solana/transfer: use hook helper to transfer tokens
TODO: the old token program still works -- is this secure? I think so but double check
Configuration menu - View commit details
-
Copy full SHA for 1123458 - Browse repository at this point
Copy the full SHA 1123458View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d49b04 - Browse repository at this point
Copy the full SHA 9d49b04View commit details -
Configuration menu - View commit details
-
Copy full SHA for 29fb437 - Browse repository at this point
Copy the full SHA 29fb437View commit details
Commits on Apr 18, 2024
-
solana: add counter to dummy transfer hook
to be able to test if it was executed
Configuration menu - View commit details
-
Copy full SHA for 4b55b84 - Browse repository at this point
Copy the full SHA 4b55b84View commit details -
wip: transfer before burn/mint to trigger hooks
wip because with this the test tx size is 5 bytes larger (for transfer) than the limit. The way to mitigate is to introduce lookup tables. That mitigation will exist in the tests, but will also have to be done on real deployments (since the transfer hooks might add an arbitrary number of extra acconuts, so we should leave as much headroom as possible)
Configuration menu - View commit details
-
Copy full SHA for 637c03e - Browse repository at this point
Copy the full SHA 637c03eView commit details
Commits on Apr 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a3ccab3 - Browse repository at this point
Copy the full SHA a3ccab3View commit details
Commits on Apr 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 18ebdc1 - Browse repository at this point
Copy the full SHA 18ebdc1View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.