Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow filtering txs by status #7

Merged
merged 2 commits into from
Dec 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions src/db.rs
Original file line number Diff line number Diff line change
Expand Up @@ -734,7 +734,13 @@ impl Database {
pub async fn read_txs(
&self,
relayer_id: &str,
tx_status_filter: Option<Option<TxStatus>>,
0xKitsune marked this conversation as resolved.
Show resolved Hide resolved
) -> eyre::Result<Vec<ReadTxData>> {
let (should_filter, status_filter) = match tx_status_filter {
Some(status) => (true, status),
None => (false, None),
};

Ok(sqlx::query_as(
r#"
SELECT t.id as tx_id, t.tx_to as to, t.data, t.value, t.gas_limit, t.nonce,
Expand All @@ -743,9 +749,12 @@ impl Database {
LEFT JOIN sent_transactions s ON t.id = s.tx_id
LEFT JOIN tx_hashes h ON s.valid_tx_hash = h.tx_hash
WHERE t.relayer_id = $1
AND ($2 = true AND s.status = $3) OR $2 = false
"#,
)
.bind(relayer_id)
.bind(should_filter)
.bind(status_filter)
.fetch_all(&self.pool)
.await?)
}
Expand Down Expand Up @@ -1282,6 +1291,9 @@ mod tests {
assert_eq!(tx.nonce, 0);
assert_eq!(tx.tx_hash, None);

let unsent_txs = db.read_txs(relayer_id, None).await?;
assert_eq!(unsent_txs.len(), 1, "1 unsent tx");

let tx_hash_1 = H256::from_low_u64_be(1);
let tx_hash_2 = H256::from_low_u64_be(2);
let initial_max_fee_per_gas = U256::from(1);
Expand All @@ -1300,6 +1312,18 @@ mod tests {
assert_eq!(tx.tx_hash.unwrap().0, tx_hash_1);
assert_eq!(tx.status, Some(TxStatus::Pending));

let unsent_txs = db.read_txs(relayer_id, Some(None)).await?;
assert_eq!(unsent_txs.len(), 0, "0 unsent tx");

let pending_txs = db
.read_txs(relayer_id, Some(Some(TxStatus::Pending)))
.await?;
assert_eq!(pending_txs.len(), 1, "1 pending tx");

let all_txs = db.read_txs(relayer_id, None).await?;

assert_eq!(all_txs, pending_txs);

db.escalate_tx(
tx_id,
tx_hash_2,
Expand Down
2 changes: 1 addition & 1 deletion src/db/data.rs
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ pub struct TxForEscalation {
pub escalation_count: usize,
}

#[derive(Debug, Clone, FromRow)]
#[derive(Debug, Clone, FromRow, PartialEq, Eq)]
pub struct ReadTxData {
pub tx_id: String,
pub to: AddressWrapper,
Expand Down
22 changes: 20 additions & 2 deletions src/server/routes/transaction.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
use std::sync::Arc;

use axum::extract::{Json, Path, State};
use axum::extract::{Json, Path, Query, State};
use ethers::types::{Address, Bytes, H256, U256};
use eyre::Result;
use serde::{Deserialize, Serialize};
Expand Down Expand Up @@ -33,6 +33,13 @@ pub struct SendTxResponse {
pub tx_id: String,
}

#[derive(Debug, Clone, Serialize, Deserialize)]
#[serde(rename_all = "camelCase")]
pub struct GetTxQuery {
#[serde(default)]
pub status: Option<GetTxResponseStatus>,
}

#[derive(Debug, Clone, Serialize, Deserialize)]
#[serde(rename_all = "camelCase")]
pub struct GetTxResponse {
Expand Down Expand Up @@ -104,12 +111,23 @@ pub async fn send_tx(
pub async fn get_txs(
State(app): State<Arc<App>>,
Path(api_token): Path<ApiKey>,
Query(query): Query<GetTxQuery>,
) -> Result<Json<Vec<GetTxResponse>>, ApiError> {
if !app.is_authorized(&api_token).await? {
return Err(ApiError::Unauthorized);
}

let txs = app.db.read_txs(&api_token.relayer_id).await?;
let txs = match query.status {
Some(GetTxResponseStatus::TxStatus(status)) => {
app.db
.read_txs(&api_token.relayer_id, Some(Some(status)))
.await?
}
Some(GetTxResponseStatus::Unsent(_)) => {
app.db.read_txs(&api_token.relayer_id, Some(None)).await?
}
None => app.db.read_txs(&api_token.relayer_id, None).await?,
};

let txs =
txs.into_iter()
Expand Down