Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change owner to identity operator #549

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Conversation

Dzejkop
Copy link
Contributor

@Dzejkop Dzejkop commented Jun 28, 2023

Change is safe since in contract constructor we're setting

@Dzejkop Dzejkop self-assigned this Jun 28, 2023
@Dzejkop Dzejkop requested a review from a team as a code owner June 28, 2023 15:47
@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2023

Codecov Report

Merging #549 (a7f5d8b) into main (28a5277) will increase coverage by 26.73%.
Report is 59 commits behind head on main.
The diff coverage is 33.33%.

❗ Current head a7f5d8b differs from pull request most recent head 207e175. Consider uploading reports for the commit 207e175 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #549       +/-   ##
===========================================
+ Coverage   28.70%   55.44%   +26.73%     
===========================================
  Files          53       47        -6     
  Lines       21376     9842    -11534     
===========================================
- Hits         6137     5457      -680     
+ Misses      15239     4385    -10854     
Flag Coverage Δ
test 55.44% <33.33%> (+26.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/contracts/abi.rs 0.00% <0.00%> (-47.06%) ⬇️
src/contracts/mod.rs 78.09% <50.00%> (-0.21%) ⬇️

... and 38 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 687e9c4...207e175. Read the comment docs.

@Dzejkop Dzejkop force-pushed the change_owner_to_identity_operator branch from a7f5d8b to 207e175 Compare November 6, 2023 14:53
Copy link
Collaborator

@dcbuild3r dcbuild3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dzejkop Dzejkop merged commit 47383dd into main Nov 6, 2023
4 checks passed
@Dzejkop Dzejkop deleted the change_owner_to_identity_operator branch November 6, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants