Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support link #129

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

feat: support link #129

wants to merge 5 commits into from

Conversation

cmm-va
Copy link
Collaborator

@cmm-va cmm-va commented Sep 30, 2024

No description provided.


notifyService = inject(ThyNotifyService);

disabled = false;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没有赋值的地方

return;
}
this.modelValue = this.createLinkValue({ text: this.text, url: this.url ?? '' });
if (JSON.stringify(this.originValue) !== JSON.stringify(this.modelValue)) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lodash.isEqual

templateUrl: `./link-editor.component.html`,
standalone: true,
changeDetection: ChangeDetectionStrategy.OnPush,
imports: [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

导入 ThyNotifyModule,就不用在使用方引入 THY_NOTIFY_DEFAULT_CONFIG_PROVIDER 了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants