Make events parameter required for ListEvents #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulAsjes
approved these changes
Apr 11, 2024
mattgd
commented
Apr 11, 2024
| Events []string `url:"events,omitempty"` | ||
| Events []string `url:"events"` |
There was a problem hiding this comment.
@PaulAsjes While this change is breaking in the API (mitigated by feature flag for affected customers), I don't consider this is a breaking change in the Go SDK, so a minor bump seems appropriate. Wanted to double check to see if you had an opinion though.
There was a problem hiding this comment.
Agreed, minor bump seems fine!
mthadley
reviewed
Apr 11, 2024
mthadley
approved these changes
Apr 11, 2024
mattgd
deleted the
feature/dsync-1308-update-go-sdk-to-require-event-names-parameter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make events parameter required for ListEvents.
Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.
https://github.com/workos/workos/pull/26139