OSD (WIP) #119
Merged
OSD (WIP) #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
init OSD implementation
btzr-io
commented
Apr 30, 2018
| // Quick hack: (TODO) FIX IT! | ||
| const { bookMode, currentPage } = this.props.reader | ||
| const nextBookMode = nextProps.reader.bookMode | ||
| if (bookMode != nextBookMode) { |
There was a problem hiding this comment.
Not sure about this, needs a better way to handle this 😕
|
🎯 Performance should be a priority, I need to reduce component updates 😛 |
Made view wait for worker to load archive formats on load.
|
I just tried it out again. Loads comics and displays them in OSD. Good job! It is coming along nicely. |
|
Do you want me to merge this? |
|
@workhorsy I'm still working on this, I'll let you know when it's ready ✌️ |
|
@workhorsy I guess now you can merge this 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo
unistore( actions / reducers)https://openseadragon.github.io/docs/OpenSeadragon.Viewer.html#.event:open-failed
https://openseadragon.github.io/docs/OpenSeadragon.Viewer.html#.event:add-item-failed