Skip to content

Commit

Permalink
Remove Biome (#973)
Browse files Browse the repository at this point in the history
We switched to TypeScript Language Server so we don't need it anymore.
  • Loading branch information
sonnyp authored Jul 14, 2024
1 parent 3a8e52c commit 6a1dd63
Show file tree
Hide file tree
Showing 9 changed files with 2 additions and 69 deletions.
21 changes: 0 additions & 21 deletions build-aux/modules/biome.json

This file was deleted.

1 change: 0 additions & 1 deletion build-aux/re.sonny.Workbench.Devel.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@
],
"modules": [
"modules/blueprint-compiler.json",
"modules/biome.json",
"modules/gst-plugin-gtk4.json",
"modules/vte.json",
"modules/libshumate.json",
Expand Down
1 change: 0 additions & 1 deletion build-aux/re.sonny.Workbench.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@
],
"modules": [
"modules/blueprint-compiler.json",
"modules/biome.json",
"modules/gst-plugin-gtk4.json",
"modules/vte.json",
"modules/libshumate.json",
Expand Down
2 changes: 1 addition & 1 deletion data/app.metainfo.xml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
<release version="46.2" date="2024-07-xx">
<description translatable="no">
<ul>
<li>Update Biome to 1.8.3</li>
<li>Replace Biome with TypeScript Language Server</li>
<li>Update gst-plugin-gtk4 to 1.12.7</li>
</ul>
</description>
Expand Down
20 changes: 0 additions & 20 deletions src/application.js
Original file line number Diff line number Diff line change
Expand Up @@ -64,23 +64,7 @@ application.connect("open", (_self, files, hint) => {
load().catch(console.error);
});

let proc_biome;

application.connect("startup", () => {
// biome lsp-proxy starts a background server
// it does not get stopped and leaves a process hanging
// so manage it manually instead
// See https://github.com/workbenchdev/Workbench/issues/828
const subprocess_launcher = Gio.SubprocessLauncher.new(
Gio.SubprocessFlags.STDERR_SILENCE,
);
proc_biome = subprocess_launcher.spawnv([
"biome",
"__run_server",
"--config-path",
pkg.pkgdatadir,
]);

Library({
application,
});
Expand All @@ -90,10 +74,6 @@ application.connect("startup", () => {
restoreSessions().catch(console.error);
});

application.connect("shutdown", () => {
proc_biome?.force_exit();
});

application.connect("activate", () => {
if (application.is_remote) {
bootstrap().catch(console.error);
Expand Down
2 changes: 1 addition & 1 deletion src/langs/css/CssDocument.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export class CssDocument extends Document {
},
});

// Biome doesn't support diff - it just returns one edit
// GTKCssLanguageServer doesn't support diff - it just returns one edit
// we don't want to loose the cursor position so we use this
const state = this.code_view.saveState();
applyTextEdits(text_edits, this.buffer);
Expand Down
4 changes: 0 additions & 4 deletions src/langs/javascript/JavaScriptDocument.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,6 @@ export class JavaScriptDocument extends Document {
},
});

// Biome doesn't support diff - it just returns one edit
// we don't want to loose the cursor position so we use this
const state = this.code_view.saveState();
applyTextEdits(text_edits, this.buffer);
await this.code_view.restoreState(state);
}
}
19 changes: 0 additions & 19 deletions src/langs/javascript/biome.json

This file was deleted.

1 change: 0 additions & 1 deletion src/meson.build
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ configure_file(
)

install_data('langs/vala/workbench.vala', install_dir: pkgdatadir)
install_data('langs/javascript/biome.json', install_dir: pkgdatadir)
install_data('project-readme.md', install_dir: pkgdatadir)
subdir('libworkbench')
subdir('Previewer')
Expand Down

0 comments on commit 6a1dd63

Please sign in to comment.