Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/framework launchpad #1

Open
wants to merge 8 commits into
base: trunk
Choose a base branch
from

Conversation

MathieuLamiot
Copy link
Collaborator

  • This PR migrates the plugin to the LaunchPad framework, according to the steps in WP-Launchpad documentation "Getting Started". Only the basic Launchpad framework is used, no additional modules.
  • A basic readme is added.
  • Registering the admin view "WP Hooks" is now based on the admin_menu hook, rather than plugins_loaded.

@MathieuLamiot
Copy link
Collaborator Author

The test part of the CI is failing, I opened a GH issue in Launchpad for this: wp-launchpad/launchpad#30

@CrochetFeve0251
Copy link

CrochetFeve0251 commented Jul 11, 2024

@MathieuLamiot the error inside the CI seems to be caused by the fact we don't have dependencies.

For that on that line https://github.com/wordpressfan/wordpress-debug-hooks/blob/20dddd489020f280fecc5fd9263445cb5e79fc43/.github/workflows/tests.yml#L59C1-L60C74.

We need to remove the no script argument.

@MathieuLamiot
Copy link
Collaborator Author

good catch 👍

@MathieuLamiot MathieuLamiot self-assigned this Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants