Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Run iOS E2E tests in macOS CI agent #6324

Draft
wants to merge 15 commits into
base: trunk
Choose a base branch
from

Conversation

geriux
Copy link
Contributor

@geriux geriux commented Oct 25, 2023

Related PRs:

To test CI checks should pass.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@geriux geriux force-pushed the test/running-ios-tests-buildkite branch 2 times, most recently from a4e0c49 to 5c1a898 Compare October 26, 2023 06:46
package.json Outdated
"device-tests": "cross-env NODE_ENV=test jest --maxWorkers=2 --testPathIgnorePatterns='canary|gutenberg-editor-rendering|ipad' --config jest_ui.config.js",
"device-tests-canary": "cross-env NODE_ENV=test jest --maxWorkers=2 --testPathPattern=@canary --config jest_ui.config.js",
"device-tests-ipad": "cross-env NODE_ENV=test IPAD=true jest --maxWorkers=2 --testPathPattern=@ipad --config jest_ui.config.js",
"device-tests": "APPIUM_HOME=~/.appium NODE_ENV=test jest --maxWorkers=1 --testPathIgnorePatterns='canary|gutenberg-editor-rendering|ipad' --config jest_ui.config.js",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been trying to run the tests locally myself on iOS and Android and I haven't understood the recommended mode to run Appium.

The setup automation checks for a global Appium then defers to the one installed in the local modules. What is best? Is there any advantage in installing it globally when using the version in the local node_modules "guarantees" every instance will run the same version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it is currently set up Appium installs in the local node_modules folder of the project but the drivers are installed globally so we export the APPIUM_HOME path so the drivers can be found. In terms of what's best, I'd say it's more of a preference if you want to have it installed globally.

My idea was to make it work for the migration but I'm open to suggestions. I'm all for improving the setup and making it as easy as possible 🚀

We also updated the E2E docs with the migration, any feedback with the document would be also appreciated if you find any issues when trying to run the tests locally.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In terms of what's best, I'd say it's more of a preference if you want to have it installed globally.

Oh, my preference would be to install everything locally. I find it's a cleaner setup. In fact, if it wasn't for the fact that some of the code needs to run on macOS, I'd even argue for Dockerizing the project so that we can all develop against the same image with all the same libraries etc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, my preference would be to install everything locally

Awesome!

if it wasn't for the fact that some of the code needs to run on macOS, I'd even argue for Dockerizing the project so that we can all develop against the same image with all the same libraries etc.

I agree, that would be great if we could 😄

@geriux geriux force-pushed the test/running-ios-tests-buildkite branch from 83172a1 to 1dd6c32 Compare November 2, 2023 16:44
@geriux geriux added the Testing Anything related to automated tests label Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing Anything related to automated tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants