Offline Mode: Switch to wp.editPost and wp.newPost #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kean
force-pushed
the
task/offline-mode-switch-wp-editpost
branch
5 times, most recently
from
39a2f3c
to
46ee69c
Compare
kean
force-pushed
the
task/offline-mode-switch-wp-editpost
branch
from
a1bfda6
to
24c835e
Compare
kean
commented
Apr 16, 2024
| @@ -115,7 +115,7 @@ extension RemotePostCreateParameters { | |||
| if previous.tags != tags { | |||
| changes.tags = tags | |||
| } | |||
| if previous.categoryIDs != categoryIDs { | |||
| if Set(previous.categoryIDs) != Set(categoryIDs) { | |||
There was a problem hiding this comment.
Making sure the order doesn't matter for the comparison.
momo-ozawa
reviewed
Apr 17, 2024
|
Updated changeling with all the recent PRs. |
momo-ozawa
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR switched to
wp.editPostandwp.newPost, which are relatively new endpoints (but are still 10+ years old) with multiple bug fixes, and, most important,if_not_modified_sincesupport.Can be tested using wordpress-mobile/WordPress-iOS#23022 (comment)
ℹ Please replace the above with a link to the issue this pull request addresses, as well as a summary of the implementation details.
Testing Details
ℹ Please replace this with a clear and concise description of the steps required to validate this pull request.
CHANGELOG.mdif necessary.