Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make WordPressOrgXMLRPCApiError conform to CustomNSError #790

Open
wants to merge 7 commits into
base: trunk
Choose a base branch
from
Open

Make WordPressOrgXMLRPCApiError conform to CustomNSError #790

wants to merge 7 commits into from

Commits on Apr 17, 2024

  1. Make WordPressComRestApiError CaseIterable

    @mokagio
    mokagio committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    8fb7ca2 View commit details
    Browse the repository at this point in the history

  2. Make WordPressOrgXMLRPCApiError conform to CustomNSError 

    This ensures that the error domain is the same between SPM and
Framework/CocoaPods builds.
    @mokagio
    mokagio committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    0d08c55 View commit details
    Browse the repository at this point in the history

  3. Import Foundation in WordPressOrgXMLRPCApiError* files for SPM builds

    @mokagio
    mokagio committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    eeb26d8 View commit details
    Browse the repository at this point in the history

  4. Move WordPressOrgXMLRPCApiErrorDomain definition to APIInterface

    @mokagio
    mokagio committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    277f0ca View commit details
    Browse the repository at this point in the history

  5. Add workaround to avoid WordPressOrgXMLRPCApiErrorDomain redefinition

    @mokagio
    mokagio committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    f6f0c1c View commit details
    Browse the repository at this point in the history

  6. Wrap .org XML RPC error enum in an Error-conforming struct 

    Jumping through this hoop was necessary to avoid the Swift compiler
automatically generating an error domain for the `Error` and making it
impossible to successfully redefine the domain at the `CustomNSError`
conformance site.
    @mokagio
    mokagio committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    ac15e9a View commit details
    Browse the repository at this point in the history

  7. Make WordPressOrgXMLRPCApiErrorCode into a nested enum

    @mokagio
    mokagio committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    e8ee86f View commit details
    Browse the repository at this point in the history