Offline Mode: Fix encoding for some fields in the new XMLRPC endpoints #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kean
commented
Apr 11, 2024
| @@ -35,8 +35,8 @@ public struct RemotePostUpdateParameters: Equatable { | |||
| public var ifNotModifiedSince: Date? | |||
|
|
|||
| public var status: String? | |||
| public var date: Date?? | |||
| public var authorID: Int?? | |||
| public var date: Date? | |||
There was a problem hiding this comment.
You can't remove any of these two fields on existing posts.
kean
force-pushed
the
task/offline-mode-fix-xmlrpc-encoding
branch
from
a92a99b
to
9ff448f
Compare
14 tasks
momo-ozawa
approved these changes
Apr 16, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Can be tested in the following PR wordpress-mobile/WordPress-iOS#22998
Fixes #
ℹ Please replace the above with a link to the issue this pull request addresses, as well as a summary of the implementation details.
Testing Details
ℹ Please replace this with a clear and concise description of the steps required to validate this pull request.
CHANGELOG.mdif necessary.