Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Insight entities parsing #772

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

staskus
Copy link
Contributor

@staskus staskus commented Apr 1, 2024

Description

Make values and value-types optional when parsing Insight entity counts.

Continuation of #763 related to a nit-pick comment #763 (comment)

ℹ Please replace the above with a link to the issue this pull request addresses, as well as a summary of the implementation details.

Testing Details

ℹ Please replace this with a clear and concise description of the steps required to validate this pull request.


  • Please check here if your pull request includes additional test coverage.
  • I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

@staskus staskus added the enhancement New feature or request label Apr 1, 2024
@staskus staskus requested a review from guarani April 1, 2024 09:34
Copy link
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I tested the Tags & Categories and All-Time cards in Stats and no issues.

@staskus staskus merged commit ccccd88 into trunk Apr 2, 2024
9 checks passed
@staskus staskus deleted the fix/improve-insight-entities-parsing-2 branch April 2, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants