Fix crash on unexpected plugin slugs #767
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes wordpress-mobile/WordPress-iOS#22891.
The crash happens when a WordPress plugin slug contains characters that are not in percentage encoding characters set, like
%
or non ascii.I couldn't find such plugin in the plugin directory though. Also the guidelines (here and here) seem to indicate slug is url safe. But maybe there still could be unconventional plugin slugs in the real world...
Testing Details
See the added unit test.
CHANGELOG.md
if necessary.