Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPM Prep – Use WordPressComRESTAPIInterfacing in the Objective-C consumers #761

Merged
merged 15 commits into from
Mar 24, 2024

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented Mar 22, 2024

Description

The bulk of this PR is going from wordPressComRestApi GET|POST to wordPressComRESTAPI get|post. That is, from the concrete implementation to the one referenced via the new WordPressComRESTAPIInterfacing protocol introduced in #760 .

Other than that, there are two notable changes:

  • Added baseURL: URL property to WordPressComRESTAPIInterfacing, 72c7132
  • Updated the methods in the protocol to return NSProgress *. This was always the behavior in the original WordPressComRestApi, but because the return value is discardable, I didn't notice it till I run into code that required it, 83d03ab

Testing Details

Green CI 👌

Next up

Basically, cherry-pick the work from #738 but in a neat and reviewable order:

  • Move files into Sources/ and Tests/
  • Introduce Bundle helper that differentiates between SPM and CocoaPods installations
  • Isolate core API objects in dedicated package

See also, #756, #758, #760 which are related to the SPM work but independent from this one.


  • Please check here if your pull request includes additional test coverage. — N.A.
  • I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary. — N.A.

@mokagio mokagio mentioned this pull request Mar 22, 2024
2 tasks
@mokagio mokagio changed the title Use WordPressComRESTAPIInterfacing in the Objective-C consumers SPM Prep – Use WordPressComRESTAPIInterfacing in the Objective-C consumers Mar 22, 2024
@mokagio mokagio marked this pull request as ready for review March 22, 2024 07:24
@mokagio mokagio enabled auto-merge March 22, 2024 07:24
@mokagio mokagio merged commit 7d0757c into trunk Mar 24, 2024
10 checks passed
@mokagio mokagio deleted the mokagio/use-abstraction-layer-for-all-wordpresscomrest branch March 24, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants