Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reader: Update fetch followed sites to take additional parameters #753

Merged
merged 2 commits into from
Mar 29, 2024
Merged

Reader: Update fetch followed sites to take additional parameters #753

merged 2 commits into from
Mar 29, 2024

Conversation

wargcm
Copy link
Contributor

@wargcm wargcm commented Mar 15, 2024 •
edited
Loading

See: wordpress-mobile/WordPress-iOS#15651
WordPress-iOS PR: wordpress-mobile/WordPress-iOS#22842

Description

Updates the fetch followed sites API call in ReaderTopicServiceRemote to take two additional parameters, page and number.

Testing Details

See WordPress-iOS PR.

  • Please check here if your pull request includes additional test coverage.
  • I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

@wargcm wargcm requested a review from dvdchr March 15, 2024 23:20
@wargcm wargcm self-assigned this Mar 15, 2024
@wargcm wargcm force-pushed the issue/15651-update-following-mine branch from 5240367 to 4515be4 Compare March 15, 2024 23:22
@wargcm wargcm mentioned this pull request Mar 15, 2024
Merged
14 tasks
dvdchr
dvdchr approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@dvdchr dvdchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@dvdchr dvdchr marked this pull request as ready for review March 29, 2024 16:48
@wargcm @dvdchr
Add a page and number parameter
70526db 
Updates the fetch followed sites API call in `ReaderTopicServiceRemote`
to take two additional parameters, `page` and `number`.

Author:    Chris McGraw <[email protected]>
@dvdchr dvdchr force-pushed the issue/15651-update-following-mine branch from 4515be4 to c0e2bc3 Compare March 29, 2024 17:40
@dvdchr dvdchr closed this Mar 29, 2024
@dvdchr dvdchr force-pushed the issue/15651-update-following-mine branch from c0e2bc3 to 69532b7 Compare March 29, 2024 17:47
@dvdchr dvdchr reopened this Mar 29, 2024
@dvdchr dvdchr force-pushed the issue/15651-update-following-mine branch from c0e2bc3 to 35cad56 Compare March 29, 2024 18:10
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@dvdchr dvdchr merged commit c2a51c2 into trunk Mar 29, 2024
9 checks passed
@dvdchr dvdchr deleted the issue/15651-update-following-mine branch March 29, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvdchr dvdchr dvdchr approved these changes

Assignees

@wargcm wargcm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wargcm @dangermattic @dvdchr