Remove Alamofire as a library dependency #736
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The apps has been running with
useURLSession
turned on for a couple of weeks. See wordpress-mobile/WordPress-iOS#22540 and woocommerce/woocommerce-ios#11927. There is no major issue reported. And it's likely we'll fix bugs in the new implementation, instead of reverting back to the old one.This PR removes Alamofire as a dependency to the library, but it's still used in the unit tests to verify some encoding request encoding implementations, i.e. multipart-form.
Testing Details
Changes are covered by unit tests.
CHANGELOG.md
if necessary.