Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Gravatar QuickEditor #21312

Draft
wants to merge 5 commits into
base: adam/gravatar_2.0.0
Choose a base branch
from

Conversation

AdamGrzybkowski
Copy link
Contributor

This PR implements the QuickEditor from the Gravatar SDK. It fully replaces the Avatar update flow, including uploading already existing photos or new ones from the camera.

A few things worth noting:

  • One of Gravatar's compose dependencies bumps the foundation library. This caused the WP build to fail because a few things got deprecated. These issues were fixed in 5b1adac. If you would prefer, I can update the compose BOM (only this specific artifact) and apply those changes in a separate PR.
  • Gravatar uses UCrop like the WP app. We found an issue though, where the cropped image size (file size) is not changed. We've tried to fix that in UCrop (PR) but things aren't moving fast there, so we released the Automattic fork with the fix applied. I had to update WP to the Automattic version to not cause conflicts.

Here's how the QuickEditor looks like in WP

jp_gravatar.mp4

To Test:


Regression Notes

  1. Potential unintended areas of impact

    • TODO
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • TODO
  3. What automated tests I added (or what prevented me from doing so)

    • TODO

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@AdamGrzybkowski AdamGrzybkowski added the Do Not Merge In PRs with this label, our automation will fail a require check, preventing accidental merging label Oct 18, 2024
@dangermattic
Copy link
Collaborator

1 Error
🚫 Please add tests for class GravatarQuickEditorFeatureConfig (or add unit-tests-exemption label to ignore this).
1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

Copy link

sonarcloud bot commented Oct 18, 2024

@wpmobilebot
Copy link
Contributor

Project dependencies changes

Content exceeds 65400 characters. Navigate to Buildkite build artifacts to see details.

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21312-6d1bc0a
Commit6d1bc0a
Direct Downloadjetpack-prototype-build-pr21312-6d1bc0a.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21312-6d1bc0a
Commit6d1bc0a
Direct Downloadwordpress-prototype-build-pr21312-6d1bc0a.apk
Note: Google Login is not supported on these builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Merge In PRs with this label, our automation will fail a require check, preventing accidental merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants