Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge some of the WordPress lint rules, to reduce number of reported issues #21256

Draft
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Draft

Merge some of the WordPress lint rules, to reduce number of reported issues #21256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f6ef532
Add a TODO prefix to security warnings comment
wzieba Sep 24, 2024
38a83ba
Ignore `UnknownNullness` lint check
wzieba Sep 24, 2024
e210382
temp: use wip version of wordpress lint checks
wzieba Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ ext {

// other
androidDesugarVersion = '2.1.2'
wordPressLintVersion = '2.1.0'
wordPressLintVersion = '20-b48dc8345c25641937b3c96b77079d05b0c24da3'
}

measureBuilds {
Expand Down
4 changes: 3 additions & 1 deletion config/lint/lint.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
<!-- EDITOR -->
<ignore path="**/org.jsoup/**" /> <!-- jsoup -->
</issue>
<!-- After addressing them, remove the below set of security issues from this list -->
<!-- TODO: After addressing them, remove the below set of security issues from this list -->
<issue id="MissingAutoVerifyAttribute" severity="warning" />
<issue id="SensitiveExternalPath" severity="warning" />
<issue id="WeakPrng" severity="warning" />
Expand Down Expand Up @@ -79,4 +79,6 @@

<!-- TODO: https://github.com/wordpress-mobile/WordPress-Android/issues/21065 -->
<issue id="UsingMaterialAndMaterial3Libraries" severity="warning" />
<!-- We rely on more granural checks from WordPress-Lint-Android -->
<issue id="UnknownNullness" severity="ignore" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion (💡): Instead of ignoring UnknownNullness I actually recommend we revert #19116 and remove all the configuration related to that, effectively removing it, not ignoring. 🤔

</lint>
Loading