-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Xcode 15.3 in CI #1392
base: tooling/fix-sync-pod-publication
Are you sure you want to change the base?
Use Xcode 15.3 in CI #1392
Conversation
> Non-'@objc' instance method in extensions cannot be overridden; > use 'public' instead
Ideally, this should be removed once the warnings have been addressed
3ee1f22
to
5baf0b9
Compare
41dc7e0
to
e41da8f
Compare
The test that locks is |
…' into mokagio/xcode-15.3
@mokagio This should fix the `testPaste{Image,Video}WithoutFormatting` test failures. - I have searched the code for `decodeObject(forKey` occurrences and confirmed there wasn't any left - But I have not triple-checked that *every* custom subclass of anything we might encode in our `NSAttributedString` attributes have had `+supportsSecureCoding` redefined Indeed, apparently, **even if** the parent class already overrides it to return `true`, subclasses which override `init?(coder:)`/`encode(with:)` from their parent class need to also re-override `+supportsSecureCoding`. I've added the overrides in classes that I've modified, but there may be more classes that might not be covered by our unit tests around archiving/pasting but would still require it to be added? So would be worth making another pass to be sure we didn't forget any,
@mokagio I took the liberty to push a commit (665b15b) to fix the [EDIT]I later fixed that commit 665b15b with c67821c[/EDIT]
Indeed, apparently, even if the parent class already overrides it to return I've added the overrides in classes that I've modified, but haven't check if maybe there are more classes that might not be covered by our unit tests around |
…inText` Since newer versions of iOS use this new `public.utf8-plain-text` UTI instead of `public.plain-text` like in previous OS versions.
This reverts commit 5c3004b, because I'm not convinced that's a good idea. We should double-check that **not** having `+supportsSecureCoding` declared on this subclass doesn't make it fail to be copy/pasted (i.e. archived/unarchived)—like similar cases happened when running Aztec tests. Or if we need `+supportsSecureCoding`, we need to find a way to override/redefine it across module boundaries…
@mokagio Just also pushed 90c0e4d to fix the
There's also still another test failing, this time in |
bfa54e2
to
80efcd7
Compare
80efcd7
to
83e548f
Compare
Builds on top of #1391, where I noticed that CI didn't run because we no longer have agents with Xcode 13 online.
To test: See green CI running on Xcode 15.3 image... via #1393 which marks four tests as expected failures 😞
CHANGELOG.md
if necessary.