Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #585: Create end2end test for expand/exit buttons in project page #620

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yue7xu
Copy link

@yue7xu yue7xu commented Dec 9, 2024

Create layout_02_fullscreen_expand_exit.spec.ts(a suit of end to end test of expand/exit full screen for four tiles). ignore other adjustment(failture to add uiid)

Context

This pull request addresses Issue #585 by creating an end-to-end test suite to verify the expand and exit fullscreen functionality for four tiles (palette, guide, stage, source) on the project page.

The test ensures:
Each tile's expand button successfully transitions the tile to fullscreen mode.
The exit fullscreen button properly reverts the tile to its original state.
The functionality works consistently across all four tiles.

Related issues

Verification

Run the test suite using the Playwright test runner, and all tests pass without errors.

Checklist

  • Created new test file layout_02_fullscreen_expand_exit.spec.ts.
  • Verified functionality for all four tiles (palette, guide, stage, source).
  • Ran tests locally using Playwright to ensure no failures.
  • Expand for additional tiles or sources that users may dynamically create.
  • Identify and Categorize Untested UI Components(e.g., navigation, buttons, modals, sliders).

…test of expand/exit full screen for four tiles). ignore other adjustment(failture to add uiid)
Copy link
Collaborator

@amyjko amyjko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has multiple files that are updated that should not be updated or included in this PR:

  • package.json
  • package-lock.json
  • vite.config...

The PR also creates a redundant end-to-end test folder; everything should be organized in /tests/end2end, rather than creating a new place to store tests. That includes the example test should not be included; that is not part of our project.

The `test-examples1 folder you have added should also be removed; that is not part of the project.

There should not be additions to the SerializedLayout type. That is the data that is stored between browser sessions and tabs, and it should not contain test information.

Please address all of these issues and then I'll re-review. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants