Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 376: Non-Uniform Pronouns in Chinese UI Fixed #613

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

awang040403
Copy link
Contributor

Context

The issue is that there are non uniform pronouns for referring to director in simplified Chinese tutorial. “你” and “您” and “他” and “她” (you, more respectful you, he, she) are all used in the Chinese tutorial to refer to the director. Sometimes he/she avoided too obviously to avert this issue and becomes awkward. I have now changed everything referring to director to ”你“, more often used second person pronoun. I also changed all "他“ and ”她“ referring to different functions to "它“, the pronoun similar "it" for lifeless objects or objects that you do not know gender.

Related issues

None

Verification

I have spent some time to double check if I have transform all uniform pronouns for the director and for functions.

Checklist

The issue is solved and ready to be evaluated.

@amyjko amyjko self-requested a review December 6, 2024 03:03
Copy link
Collaborator

@amyjko amyjko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you for this careful audit.

@amyjko amyjko merged commit 1912e9f into wordplaydev:main Dec 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants