[Wordle] 애쉬(김동호) 미션 제출합니다. #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjlee38
reviewed
May 13, 2022
|
|
||
| private fun isRightSize(): Boolean = value.length == SIZE | ||
|
|
||
| private fun isAlphabet(): Boolean = Regex("^[a-zA-Z]*$").matches(value) |
There was a problem hiding this comment.
찾아보니 char 타입에 isLetter 라는 메소드가 있네요~ 이걸 활용해보면 어떨까요 ?
There was a problem hiding this comment.
isLetter는 한글도 letter로 인식하네요..ㅠㅠ
There was a problem hiding this comment.
아하 그렇군요. 저번 시간에 배운 확장함수를 이용해보는 것도 재밌을 것 같아요 👍
cjlee38
reviewed
May 19, 2022
|
|
||
| private fun isRightSize(): Boolean = value.length == SIZE | ||
|
|
||
| private fun isAlphabet(): Boolean = Regex("^[a-zA-Z]*$").matches(value) |
There was a problem hiding this comment.
아하 그렇군요. 저번 시간에 배운 확장함수를 이용해보는 것도 재밌을 것 같아요 👍
|
안녕하세요 애쉬~ 피드백 반영하신 내용 확인했습니다. 코드에서 더 이상 수정하실 건 없을 것 같고, 함께 고민해볼 포인트들이 몇 가지 있는 것 같아 그 부분만 한번 생각해보시고 답변 달아주시면 감사하겠습니다~ 미션하시느라 고생 많으셨어요 ! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.