Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] - Prometheus, Grafana, Loki 설정 추가 #603

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

hangillee
Copy link

✅ 작업 내용

  • Prometheus 의존성 추가
  • Grafana 설정 추가
  • Loki 관련 Logback 설정 추가

Copy link

Test Results

 30 files  ±0   30 suites  ±0   8s ⏱️ -1s
291 tests ±0  290 ✅ ±0  1 💤 ±0  0 ❌ ±0 
304 runs  ±0  303 ✅ ±0  1 💤 ±0  0 ❌ ±0 

Results for commit 71b43c2. ± Comparison against base commit a0eafdb.

Copy link
Member

@nak-honest nak-honest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 입니닷!!

Comment on lines +7 to +13
<springProfile name="local">
<property name="LOKI_URL" value="http://localhost:3100/loki/api/v1/push"/>
</springProfile>
<springProfile name="dev">
<property name="LOKI_URL" value="http://loki:3100/loki/api/v1/push"/>
</springProfile>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이후에 prod 만 까먹지 않으면 될 것 같슴다!
저도 기억하고 있을게요 ㅎㅎ

Copy link

@Libienz Libienz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

내부적으로 공유된 사안이라 어프루브 드립니다~

Copy link

@slimsha2dy slimsha2dy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@hangillee hangillee merged commit ff30ab1 into develop/be Nov 26, 2024
3 checks passed
@hangillee hangillee deleted the feature/be/#599 branch November 26, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants