[Fix] 프로필 사진 빈 값 예외처리 삭제 #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Test Results 30 files 30 suites 8s ⏱️ Results for commit a89a0db. ♻️ This comment has been updated with latest results. |
nak-honest
approved these changes
Oct 19, 2024
Comment on lines
+69
to
73
| private boolean isUpdatable(String requestProfileImageUrl, Member member) { | ||
| return !requestProfileImageUrl.isEmpty() && !Objects.equals(requestProfileImageUrl, | ||
| member.getProfileImageUrl()); | ||
| } | ||
| } |
There was a problem hiding this comment.
해당 부분은 프론트 분들과 함께 이야기 나눈 것으로 기억하는데,
지금 생각해보면 기존에 가지고 있는 url을 넘기는 것이 더 좋지 않을까라는 생각이 드네요!
빈 문자열로 들어올땐 프사를 바꾸지 않는다는 것이 약간은 숨겨진 로직일 수 있을 것 같아서요!
다음에 프론트분들과도 이야기 같이 해 보시죠!!
There was a problem hiding this comment.
빈 문자열로 들어오면 빈 문자열로 바꾸고 기본 이미지는 프론트에서 처리하기로 했습니답
그래서 실제로 빈 문자열로 저장하고 s3 작업만 안 하도록 했는데 이것도 그럴까요?
There was a problem hiding this comment.
아하 제가 로직을 좀 착각했네요 ㅎㅎ
이대로 가면 될 것 같슴다!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 작업 내용