Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] - PR을 생성 할 때 빌드 및 테스트 하는 CI Workflow 추가 #41

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

nak-honest
Copy link
Member

@nak-honest nak-honest commented Jul 16, 2024

✅ 작업 내용

  • production/be, develop/be 로 PR 생성 시 빌드 및 테스트 하도록 github action workflow 작성
    • 빌드 및 테스트 실패시 PR을 merge 할 수 없도록 branch protection rule 설정
    • 테스트 결과를 PR comment로 남기도록 yml 작성
    • 테스트가 실패하는 코드에 리뷰를 남기도록 yml 작성

🙈 참고 사항

yml 파일 이름 변경

  • be-ci.yml
  • be-dev-ci-cd.yml -> be-cd-dev.yml

@nak-honest nak-honest added the BE label Jul 16, 2024
@nak-honest nak-honest added this to the sprint 2 milestone Jul 16, 2024
Copy link

github-actions bot commented Jul 16, 2024

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit be4bb21.

♻️ This comment has been updated with latest results.

- be-pull-request.yml -> be-ci.yml
- be-dev-ci-cd.yml -> be-cd-dev.yml
Comment on lines +30 to +41
- name: Publish Unit Test Results
uses: EnricoMi/publish-unit-test-result-action@v1
if: ${{ always() }}
with:
files: ./build/test-results/**/*.xml

- name: When test fail, comment on that code
uses: mikepenz/action-junit-report@v3
if: always()
with:
report_paths: ./build/test-results/**/*.xml
token: ${{ github.token }}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

테스트 시각화 봇 👍👍

Comment on lines -1 to 4
name: BE DEV CI/CD
name: BE CD DEV

on:
push:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

파일명과 이름 변경 확인했습니다

Copy link

@slimsha2dy slimsha2dy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 너무 수고하셨습니다 낙낙

@nak-honest nak-honest merged commit f9c5fcf into develop/be Jul 16, 2024
3 checks passed
@nak-honest nak-honest deleted the feature/be/#40 branch July 16, 2024 08:14
@nak-honest nak-honest linked an issue Jul 16, 2024 that may be closed by this pull request
4 tasks
eunjungL pushed a commit that referenced this pull request Jul 30, 2024
* feat: pull request workflow 생성

* refactor: github action workflow yml 파일 이름 변경

- be-pull-request.yml -> be-ci.yml
- be-dev-ci-cd.yml -> be-cd-dev.yml
hangillee pushed a commit to hangillee/2024-touroot that referenced this pull request Aug 20, 2024
* feat: pull request workflow 생성

* refactor: github action workflow yml 파일 이름 변경

- be-pull-request.yml -> be-ci.yml
- be-dev-ci-cd.yml -> be-cd-dev.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Feature] - PR을 생성 할 때 빌드 및 테스트 하는 CI Workflow 추가
3 participants