Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] 테스트 코드 리팩토링 #730

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

[BE] 테스트 코드 리팩토링 #730

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
bc56f07
refactor: 인수 테스트 복구
woosung1223 Nov 13, 2023
c209ebd
chore: 불필요한 코드 제거, 스타일 조정
woosung1223 Nov 13, 2023
1fa27ea
chore: 불필요한 어노테이션 삭제
woosung1223 Nov 13, 2023
3a2aca5
refactor: `@AutoConfigureMockMvc`를 사용하고 있으므로 `setUp` 메소드 삭제
woosung1223 Nov 13, 2023
9c296bc
chore: `GenerationStrategy`를 `IntegrationTest`로 이동, 불필요한 의존성 제거
woosung1223 Nov 13, 2023
4b08854
refactor: 인증 관련 메소드를 상위 클래스에 두지 않고 `AuthIntegrationTest`로 이동
woosung1223 Nov 13, 2023
431ad83
chore: `@Disabled` 처리된 테스트 복구
woosung1223 Nov 13, 2023
81f6419
chore: 메소드명 변경, 모든 테스트가 `TestEntityManager`가 아닌 `EntityManager`를 사용하도…
woosung1223 Nov 13, 2023
13bb5a6
chore: unused import 제거
woosung1223 Nov 21, 2023
bc6e3bf
chore: softly 선언이 되고 있지 않던 문제 해결
woosung1223 Nov 21, 2023
2a90fdf
chore: 매직 넘버 제거
woosung1223 Nov 21, 2023
5d0cb9a
chore: 인수 테스트 로그인 순서 복구
woosung1223 Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions backend/src/test/java/harustudy/backend/integration/IntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
import harustudy.backend.auth.util.JwtTokenProvider;
import harustudy.backend.member.domain.LoginType;
import harustudy.backend.member.domain.Member;
import harustudy.backend.participantcode.domain.GenerationStrategy;
import jakarta.persistence.EntityManager;
import jakarta.persistence.PersistenceContext;
import jakarta.servlet.http.Cookie;
Expand Down Expand Up @@ -48,15 +49,15 @@ class IntegrationTest {
@Autowired
protected MockMvc mockMvc;

@Autowired
private WebApplicationContext webApplicationContext;

@Autowired
private JwtTokenProvider jwtTokenProvider;

@Autowired
private TokenConfig tokenConfig;

@Autowired
protected GenerationStrategy generationStrategy;

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요 GenerationStrategy를 다른 통합테스트에서도 participantCode를 생성하는데 사용했다면 IntegrationTest로 올려도 좋을 것 같습니다. 하지만 지금 저희 통합 테스트에서는 StudyIntegrationTest에서만 사용하는 것 같아 StudyIntegrationTest에서 관리하는 것이 괜찮을 것 같은데 어떻게 생각하시는지 궁금합니다 😃

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 저도 이 부분 고민했었는데,

현재는 IntegrationTest에서 모든 의존성이 드러나고 있어서 GenerationStrategy도 올리는게 낫지 않을까 생각을 했었습니다!
(매번 통합 테스트에서 어떤 의존성을 어디서 선언할지 고민하지 않아도 되고요)

그런데 이 부분은 저도 고민 많이 했던 내용이라, 팀 논의를 먼저 해보면 좋을 것 같아요!

@MockBean
private OauthClients oauthClients;

Expand Down
9 changes: 0 additions & 9 deletions backend/src/test/java/harustudy/backend/integration/StudyIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,15 +35,6 @@
@SuppressWarnings("NonAsciiCharacters")
class StudyIntegrationTest extends IntegrationTest {

@Autowired
private ObjectMapper objectMapper;

@Autowired
private EntityManager entityManager;

@Autowired
private GenerationStrategy generationStrategy;

private Study study1;
private Study study2;
private MemberDto memberDto1;
Expand Down