[BE] feat: 꿀조합 검색 기능 구현 #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wugawuga
reviewed
Aug 16, 2023
Comment on lines
+32
to
+46
| public static SearchRecipeResultDto toDto(final Recipe recipe, final List<RecipeImage> images, | ||
| final List<Product> products) { | ||
| final List<ProductRecipeDto> productRecipes = products.stream() | ||
| .map(ProductRecipeDto::toDto) | ||
| .collect(Collectors.toList()); | ||
|
|
||
| if (images.isEmpty()) { | ||
| return new SearchRecipeResultDto(recipe.getId(), null, recipe.getTitle(), | ||
| RecipeAuthorDto.toDto(recipe.getMember()), productRecipes, recipe.getFavoriteCount(), | ||
| recipe.getCreatedAt()); | ||
| } | ||
| return new SearchRecipeResultDto(recipe.getId(), images.get(0).getImage(), recipe.getTitle(), | ||
| RecipeAuthorDto.toDto(recipe.getMember()), productRecipes, recipe.getFavoriteCount(), | ||
| recipe.getCreatedAt()); | ||
| } |
There was a problem hiding this comment.
dto 안에서 dto 를 만드는 것은 가독성이 떨어지는 것 같아요
밖에서 dto 를 다 만들어서 애초부터 넣는 방식은 어떻게 생각하시나요??
There was a problem hiding this comment.
현재 레시피 패키지안에서
dto를 만드는 정적팩토리메소드는 대체로
도메인(엔티티)을 파라미터로 받아 dto를 만들고 있습니다.
저는 개인적으로 밖에서 dto를 만들면 서비스 코드가 난잡해지는 것 같아요..!
hanueleee
approved these changes
Aug 17, 2023
Comment on lines
+32
to
+46
| public static SearchRecipeResultDto toDto(final Recipe recipe, final List<RecipeImage> images, | ||
| final List<Product> products) { | ||
| final List<ProductRecipeDto> productRecipes = products.stream() | ||
| .map(ProductRecipeDto::toDto) | ||
| .collect(Collectors.toList()); | ||
|
|
||
| if (images.isEmpty()) { | ||
| return new SearchRecipeResultDto(recipe.getId(), null, recipe.getTitle(), | ||
| RecipeAuthorDto.toDto(recipe.getMember()), productRecipes, recipe.getFavoriteCount(), | ||
| recipe.getCreatedAt()); | ||
| } | ||
| return new SearchRecipeResultDto(recipe.getId(), images.get(0).getImage(), recipe.getTitle(), | ||
| RecipeAuthorDto.toDto(recipe.getMember()), productRecipes, recipe.getFavoriteCount(), | ||
| recipe.getCreatedAt()); | ||
| } |
There was a problem hiding this comment.
현재 레시피 패키지안에서
dto를 만드는 정적팩토리메소드는 대체로
도메인(엔티티)을 파라미터로 받아 dto를 만들고 있습니다.
저는 개인적으로 밖에서 dto를 만들면 서비스 코드가 난잡해지는 것 같아요..!
70825
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
✨ 구현한 기능
꿀조합 검색 기능 구현
LIKE연산📢 논의하고 싶은 내용
🎸 기타
⏰ 일정