[FE] feat: 상품 검색 자동완성 쿼리 추가 #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xodms0309
reviewed
Aug 14, 2023
|
|
||
| return data; | ||
| }; | ||
|
|
||
| const useInfiniteSearchedProductsQuery = (query: string) => { | ||
| const useInfiniteProductSearchResultsQuery = (query: string) => { |
There was a problem hiding this comment.
위 아래 다른 파일인 것 같은데 왜 hook 이름이 같죠..?
There was a problem hiding this comment.
그리고 이거 자동완성 해주는 hook이면 이름에 autocomplete 이런거 들어가면 좋을 것 같아요..아니면 results랑 똑같이 네이밍을 해서 useInfiniteProductSearchResultQuery, useInifniteProductSearchQuery 이런식으로..? 이름이 너무 헷갈려요
There was a problem hiding this comment.
네이밍 어렵더라구요..
결과 => Result
검색중 =>Searching으로 했는데 좀 더 생각해볼게요!
frontend/src/types/response.ts
Outdated
Comment on lines
38
to
43
| export interface SearchingProductResponse { | ||
| page: Page; | ||
| products: SearchingProduct[]; | ||
| } | ||
|
|
||
| export interface ProductSearchResultResponse { |
There was a problem hiding this comment.
이것도 SearchingProduct랑 ProductSearchResult라서 더 헷갈리는거 같아요. Searching이 자동완성인가요..?
hae-on
approved these changes
Aug 14, 2023
|
피드백 반영했습니다! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
✨ 구현한 기능
📢 논의하고 싶은 내용
x
🎸 기타
x
⏰ 일정