Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] feat: 사용자 마이페이지 꿀조합 조회 기능 구현 #435

Merged
merged 9 commits into from
Aug 14, 2023
Merged

[BE] feat: 사용자 마이페이지 꿀조합 조회 기능 구현 #435

merged 9 commits into from
Aug 14, 2023

Conversation

wugawuga
Copy link
Collaborator

Issue

✨ 구현한 기능

  • 사용자 마이페이지 접속 시 해당 사용자 꿀조합 조회 기능 추가입니다.

📢 논의하고 싶은 내용

  • x

🎸 기타

  • x

⏰ 일정

  • 추정 시간 : 2
  • 걸린 시간 : 3

@wugawuga wugawuga self-assigned this Aug 13, 2023
@github-actions
Copy link

github-actions bot commented Aug 13, 2023 •
edited
Loading

Unit Test Results

153 tests   153 ✔️  11s ⏱️
  86 suites      0 💤
  86 files        0 ❌

Results for commit ec5e969.

♻️ This comment has been updated with latest results.

70825
70825 reviewed Aug 13, 2023
View reviewed changes
Copy link
Member

@70825 70825 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PageDto로 변경하면서 ProductsInCategoryPageDto도 PageDto로 변경하면 좋을 것 같아요~
프로덕션 코드는 깔끔해서 테스트 코드에만 수정할 부분이나 논의할 부분 코멘트 몇 개 남겼습니다!

backend/src/main/java/com/funeat/common/dto/PageDto.java Show resolved Hide resolved
backend/src/test/java/com/funeat/recipe/application/RecipeServiceTest.java Outdated Show resolved Hide resolved
backend/src/test/java/com/funeat/recipe/application/RecipeServiceTest.java Outdated Show resolved Hide resolved
backend/src/test/java/com/funeat/recipe/application/RecipeServiceTest.java Outdated Show resolved Hide resolved
backend/src/test/java/com/funeat/recipe/application/RecipeServiceTest.java Outdated Show resolved Hide resolved
backend/src/test/java/com/funeat/recipe/application/RecipeServiceTest.java Outdated Show resolved Hide resolved
backend/src/test/java/com/funeat/recipe/application/RecipeServiceTest.java Show resolved Hide resolved
Go-Jaecheol
Go-Jaecheol reviewed Aug 14, 2023
View reviewed changes
Copy link
Collaborator

@Go-Jaecheol Go-Jaecheol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PageDto 수정에서 감동받았읍니다..
코멘트 하나 남겼는데 확인해주세요~

backend/src/main/java/com/funeat/common/dto/PageDto.java Outdated Show resolved Hide resolved
backend/src/main/java/com/funeat/member/dto/MemberRecipeDto.java Show resolved Hide resolved
70825
70825 approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@70825 70825 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍

hanueleee
hanueleee requested changes Aug 14, 2023
View reviewed changes
Copy link
Collaborator

@hanueleee hanueleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PageDto 보기만해도 속이 시원😎

backend/src/main/java/com/funeat/member/presentation/MemberApiController.java Outdated Show resolved Hide resolved
@wugawuga wugawuga merged commit 1db44ac into develop Aug 14, 2023
3 checks passed
@wugawuga wugawuga deleted the feat/issue-427 branch August 14, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Go-Jaecheol Go-Jaecheol Go-Jaecheol left review comments

@hanueleee hanueleee hanueleee requested changes

@70825 70825 70825 approved these changes

Assignees

@wugawuga wugawuga

Labels
🔒 BE ✨ Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BE] 마이페이지 레시피 조회
4 participants
@wugawuga @Go-Jaecheol @70825 @hanueleee