[BE] refactor: 상품 랭킹 조회 시 Response에 카테고리 타입 추가 #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wugawuga
reviewed
Aug 12, 2023
backend/src/main/java/com/funeat/product/domain/CategoryType.java
Outdated
Show resolved
Hide resolved
wugawuga
approved these changes
Aug 12, 2023
70825
approved these changes
Aug 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
✨ 구현한 기능
상품 랭킹 조회 시 Response에 카테고리 타입 추가
RankingProductDto에categoryType추가CategoryTypeenum에 CategoryType -> String(LowerCase) 로 변환해주는 메서드 추가📢 논의하고 싶은 내용
product.getCategory().getType().name().toLowerCase()형태로 받으면 너무 길어지고 복잡한 것 같아서,CategoryTypeenum에 소문자 문자열로 변환해주는 static 메서드를 만들었는데 어떻게 생각하시나요?CategoryType에서 변환해주기 vsCategory에서 변환해주기)🎸 기타
x
⏰ 일정