[FE] feat: MemberTitle 컴포넌트 구현 #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xodms0309
reviewed
Aug 12, 2023
Comment on lines
14
to
16
| <Link> | ||
| <ArrowIcon variant="arrow" color={theme.colors.gray5} width={18} height={18} /> | ||
| </Link> |
There was a problem hiding this comment.
여기서 라우팅하려면 routeDestination같은 prop이 있어야할 것 같아요
There was a problem hiding this comment.
props 받고 경로 이동까지 처리해놓았습니다!
Leejin-Yang
approved these changes
Aug 12, 2023
| const MembersTitle = ({ title }: MembersTitleProps) => { | ||
| return ( | ||
| <MemberTitleContainer> | ||
| <Heading size="xl">{title}</Heading> |
There was a problem hiding this comment.
섹션별 타이틀이 될거 같아서 h2로 하는게 좋아보입니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
✨ 구현한 기능
memberTitle 컴포넌트를 구현하였습니다.
페이지 더 붙이고 구체적인 내용을 덧 붙일 예정입니다.
title props로 받는건 추후 api 논의 후 달라질 듯 합니다.
마크업만 봐주세요!
📢 논의하고 싶은 내용
x
🎸 기타
x
⏰ 일정