Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] feat: 프로필 타이틀 컴포넌트 구현 #404

Merged
merged 5 commits into from
Aug 12, 2023
Merged

Conversation

hae-on
Copy link
Collaborator

@hae-on hae-on commented Aug 11, 2023

Issue

✨ 구현한 기능

프로필의 타이틀 컴포넌트를 구현하였습니다.

스크린샷 2023-08-11 오후 7 30 38

📢 논의하고 싶은 내용

SectionTitle이랑 구조 비슷하게 구현하였습니다.

🎸 기타

x

⏰ 일정

  • 추정 시간 : 1시간
  • 걸린 시간 : 1시간 반

@github-actions
Copy link

github-actions bot commented Aug 11, 2023

Unit Test Results

2 tests   2 ✔️  7s ⏱️
1 suites  0 💤
1 files    0

Results for commit 87ad9fe.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@xodms0309 xodms0309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~~

<SvgIcon variant="pencil" width={20} height={24} color={theme.colors.gray3} />
</MemberModifyButton>
</MemberTitleInfoWrapper>
<Button textColor="disabled" variant="transparent">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type="button"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

매의 눈 🦅

Copy link
Collaborator

@Leejin-Yang Leejin-Yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

해온 수고했어요~!
코멘트 확인해주세요 😊

Comment on lines 21 to 23
<MemberModifyButton type="button" variant="transparent">
<SvgIcon variant="pencil" width={20} height={24} color={theme.colors.gray3} />
</MemberModifyButton>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

사용자 정보 편집 페이지는 링크로 작성하는게 좋아보여요!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

링크로 작성하고 수정 페이지 라우팅까지 해놓았습니다!

Copy link
Collaborator

@Leejin-Yang Leejin-Yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~👍

@hae-on hae-on merged commit 00dc8a3 into develop Aug 12, 2023
3 checks passed
@hae-on hae-on deleted the feat/issue-392 branch August 12, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FE] 프로필 타이틀 컴포넌트 구현
3 participants