[FE] feat: 리뷰 좋아요 디바운스 적용 #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hae-on
approved these changes
Aug 10, 2023
xodms0309
reviewed
Aug 10, 2023
frontend/src/hooks/useDebounce.ts
Outdated
| @@ -0,0 +1,35 @@ | |||
| import { useCallback, useEffect, useRef } from 'react'; | |||
|
|
|||
| // eslint-disable-next-line @typescript-eslint/ban-types | |||
There was a problem hiding this comment.
Function 타입을 쓸 수 없어서 임의로 했읍니다..
린트 설정에 추가할까요?
Comment on lines
+28
to
+30
| useEffect(() => { | ||
| return clear; | ||
| }, []); |
There was a problem hiding this comment.
clear만 따로 useEffect 선언해주는 이유는 뭔가요??
There was a problem hiding this comment.
언마운트 될 때 타임아웃 클리어 하기 위해 작성했읍니다!
| return clear; | ||
| }, []); | ||
|
|
||
| return [debounce, clear]; |
There was a problem hiding this comment.
순서 걱정 없는 객체로 리턴하는건 어떤가요?!
There was a problem hiding this comment.
쓰는 곳에서 자유롭게 이름을 수정하기 위해 작성했습니다
{debounce: debouncedToggleFavorite} 이 형태가 너무 길어질거 같아서요
|
린트 설정 수정했습니다 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
✨ 구현한 기능
📢 논의하고 싶은 내용
🎸 기타
x
⏰ 일정