[BE] feat: 꿀조합 상세 정보 조회 기능 #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wugawuga
approved these changes
Aug 9, 2023
Comment on lines
88
to
90
| return recipeFavoriteRepository.findByMemberAndRecipe(member, recipe) | ||
| .map(RecipeFavorite::getChecked) | ||
| .orElse(false); |
There was a problem hiding this comment.
이거 쿼리 메소드로 수정이 가능할 것 같습니다.
어떻게 생각하시나용?
70825
reviewed
Aug 10, 2023
backend/src/test/java/com/funeat/acceptance/recipe/RecipeAcceptanceTest.java
Outdated
Show resolved
Hide resolved
backend/src/test/java/com/funeat/acceptance/recipe/RecipeAcceptanceTest.java
Outdated
Show resolved
Hide resolved
backend/src/test/java/com/funeat/acceptance/recipe/RecipeAcceptanceTest.java
Outdated
Show resolved
Hide resolved
backend/src/test/java/com/funeat/product/persistence/ProductRecipeRepositoryTest.java
Outdated
Show resolved
Hide resolved
backend/src/test/java/com/funeat/recipe/application/RecipeServiceTest.java
Outdated
Show resolved
Hide resolved
backend/src/test/java/com/funeat/recipe/application/RecipeServiceTest.java
Outdated
Show resolved
Hide resolved
backend/src/test/java/com/funeat/recipe/application/RecipeServiceTest.java
Outdated
Show resolved
Hide resolved
backend/src/test/java/com/funeat/recipe/application/RecipeServiceTest.java
Outdated
Show resolved
Hide resolved
backend/src/test/java/com/funeat/recipe/persistence/RecipeImageRepositoryTest.java
Outdated
Show resolved
Hide resolved
backend/src/test/java/com/funeat/recipe/persistence/RecipeImageRepositoryTest.java
Outdated
Show resolved
Hide resolved
Go-Jaecheol
reviewed
Aug 10, 2023
backend/src/main/java/com/funeat/member/domain/favorite/RecipeFavorite.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
✨ 구현한 기능
꿀조합 상세 정보 조회 기능
📢 논의하고 싶은 내용
Interceptor의 PathPattern
현상태 :
/api/recipes로 들어오는 요청이고GET이 아니면 RecipeHandlerInterceptor 작동🎸 기타
Review형식에 맞춰서Recipe에도FavoriteCount추가Recipe의name필드를title로 수정⏰ 일정