Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] feat: 꿀조합 작성 기능 구현 #349

Merged
merged 15 commits into from
Aug 9, 2023
Merged

[BE] feat: 꿀조합 작성 기능 구현 #349

merged 15 commits into from
Aug 9, 2023

Conversation

hanueleee
Copy link
Collaborator

@hanueleee hanueleee commented Aug 8, 2023 •
edited
Loading

Issue

✨ 구현한 기능

꿀조합 작성 기능

📢 논의하고 싶은 내용

  • ImageService와 ImageUploader의 위치 (현위치 : review 패키지 밑)
  • review.image.path 명칭 수정
  • AuthInterceptor
    • /api/recipes : POST는 거쳐야함. GET은 패스해야함.
    • /api/products/**/reviews/** : POST, GET, PATCH 전부 거쳐야함.
    • /api/members : PUT, GET 전부 거쳐야함.

🎸 기타

  • X

⏰ 일정

  • 추정 시간 : 5
  • 걸린 시간 : 5

@hanueleee hanueleee self-assigned this Aug 8, 2023
@github-actions
Copy link

github-actions bot commented Aug 8, 2023 •
edited
Loading

Unit Test Results

69 tests   69 ✔️  9s ⏱️
36 suites    0 💤
36 files      0 ❌

Results for commit c723006.

♻️ This comment has been updated with latest results.

wugawuga
wugawuga reviewed Aug 8, 2023
View reviewed changes
Copy link
Collaborator

@wugawuga wugawuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

레시피 기능 구현 수고하셨습니당!!!

backend/src/main/java/com/funeat/review/application/ReviewService.java Outdated Show resolved Hide resolved
Go-Jaecheol
Go-Jaecheol approved these changes Aug 8, 2023
View reviewed changes
Copy link
Collaborator

@Go-Jaecheol Go-Jaecheol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ImageService와 ImageUploader의 위치 (현위치 : review 패키지 밑)

=> review, recipe에서 둘 다 사용중이니 common 패키지 밑으로 이동하는 것 좋아보여요!

review.image.path 명칭 수정

=> 해당 부분 수정하면서 젠킨스 환경 변수 수정도 같이 해주세용

70825
70825 reviewed Aug 8, 2023
View reviewed changes
Copy link
Member

@70825 70825 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good 👍 테스트 코드쪽에 리뷰 몇 개 달아두었는데 수정하면 좋을 것 같아요~

backend/src/test/java/com/funeat/recipe/application/RecipeServiceTest.java Outdated Show resolved Hide resolved
backend/src/test/java/com/funeat/acceptance/recipe/RecipeAcceptanceTest.java Outdated Show resolved Hide resolved
backend/src/test/java/com/funeat/acceptance/recipe/RecipeAcceptanceTest.java Outdated Show resolved Hide resolved
wugawuga
wugawuga approved these changes Aug 9, 2023
View reviewed changes
Copy link
Collaborator

@wugawuga wugawuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!!! LGTM~~ 👍

70825
70825 approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@70825 70825 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

테스트 코드 깔끔해졌네요! 고생하셨습니다~

@hanueleee hanueleee merged commit 9655a66 into develop Aug 9, 2023
3 checks passed
@hanueleee hanueleee deleted the feat/issue-185 branch August 9, 2023 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Go-Jaecheol Go-Jaecheol Go-Jaecheol approved these changes

@wugawuga wugawuga wugawuga approved these changes

@70825 70825 70825 approved these changes

Assignees

@hanueleee hanueleee

Labels
🔒 BE ✨ Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BE] 꿀조합 작성 기능 구현
4 participants
@hanueleee @Go-Jaecheol @70825 @wugawuga