Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] fix: 트랜잭션 전파 옵션을 설정 #300

Merged
merged 2 commits into from
Aug 3, 2023
Merged

[BE] fix: 트랜잭션 전파 옵션을 설정 #300

merged 2 commits into from
Aug 3, 2023

Conversation

70825
Copy link
Member

@70825 70825 commented Aug 3, 2023 •
edited
Loading

Issue

✨ 구현한 기능

    1. 트랜잭션 전파 옵션을 REQUIRES_NEW로 설정합니다.
    1. 테스트에서는 REQUIRES_NEW를 하면 서비스 테스트만 새로운 트랜잭션이 생성되어서 해당 메서드만 따로 격리가 되기 때문에 테스트가 불가능합니다.
      그래서 기존 서비스를 상속하는 테스트용 서비스를 제작하여 REQUIRES_NEW인 테스트만 @Transactional로 변경했습니다.

📢 논의하고 싶은 내용

  • x

🎸 기타

  • x

⏰ 일정

  • 추정 시간 : 0.5
  • 걸린 시간 : 0.5

@70825 70825 self-assigned this Aug 3, 2023
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

Unit Test Results

67 tests   67 ✔️  8s ⏱️
34 suites    0 💤
34 files      0 ❌

Results for commit 05394df.

hanueleee
hanueleee approved these changes Aug 3, 2023
View reviewed changes
Copy link
Collaborator

@hanueleee hanueleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

트랜잭션 마스터 로우거언

Go-Jaecheol
Go-Jaecheol approved these changes Aug 3, 2023
View reviewed changes
Copy link
Collaborator

@Go-Jaecheol Go-Jaecheol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

해당 서비스 메서드를 테스트하기 위해서는 이 방법이 최선인 것 같아요!!

wugawuga
wugawuga approved these changes Aug 3, 2023
View reviewed changes
Copy link
Collaborator

@wugawuga wugawuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~👍

@70825 70825 merged commit e27cee1 into develop Aug 3, 2023
3 checks passed
@70825 70825 deleted the feat/issue-298 branch August 3, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanueleee hanueleee hanueleee approved these changes

@wugawuga wugawuga wugawuga approved these changes

@Go-Jaecheol Go-Jaecheol Go-Jaecheol approved these changes

Assignees

@70825 70825

Labels
🔒 BE 🐛 Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BE] 트랜잭션 전파 옵션을 REQUIRES_NEW로 변경하여 새로운 트랜잭션 생성
4 participants
@70825 @Go-Jaecheol @wugawuga @hanueleee