Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] fix: 로그인된 회원 기준으로 좋아요 조회되게 수정 #293

Merged
merged 2 commits into from
Aug 3, 2023
Merged

[BE] fix: 로그인된 회원 기준으로 좋아요 조회되게 수정 #293

merged 2 commits into from
Aug 3, 2023

Conversation

wugawuga
Copy link
Collaborator

@wugawuga wugawuga commented Aug 3, 2023

Issue

✨ 구현한 기능

  • 로그인된 회원 기준으로 좋아요 조회되게 수정

📢 논의하고 싶은 내용

  • x

🎸 기타

  • x

⏰ 일정

  • 추정 시간 : 0.2
  • 걸린 시간 : 0.2

@wugawuga wugawuga self-assigned this Aug 3, 2023
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

Unit Test Results

67 tests   67 ✔️  10s ⏱️
34 suites    0 💤
34 files      0 ❌

Results for commit 0f16e8b.

70825
70825 approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@70825 70825 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이제 유저마다 어떤 리뷰에 좋아요를 눌렀는지 제대로 보일 수 있을 것 같네요 👍👍

backend/src/main/java/com/funeat/member/domain/favorite/ReviewFavorite.java Show resolved Hide resolved
hanueleee
hanueleee approved these changes Aug 3, 2023
View reviewed changes
Copy link
Collaborator

@hanueleee hanueleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿~~

Go-Jaecheol
Go-Jaecheol approved these changes Aug 3, 2023
View reviewed changes
Copy link
Collaborator

@Go-Jaecheol Go-Jaecheol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 작성자가 아니라 사용자를 기준으로 비교했어야 되는데 이걸 저번에 다 같이 생각 못했었네요ㅜㅜ
고생하셨습니다~!

@wugawuga wugawuga merged commit fd15941 into develop Aug 3, 2023
3 checks passed
@wugawuga wugawuga deleted the fix/issue-290 branch August 3, 2023 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanueleee hanueleee hanueleee approved these changes

@70825 70825 70825 approved these changes

@Go-Jaecheol Go-Jaecheol Go-Jaecheol approved these changes

Assignees

@wugawuga wugawuga

Labels
🔒 BE 🐛 Bug ✨ Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BE] fix: 리뷰 좋아요, 해당 세션 회원과 비교
4 participants
@wugawuga @Go-Jaecheol @70825 @hanueleee