Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] feat: 리뷰 작성과 리뷰 좋아요 기능에 로그인 붙이기 #206

Merged
merged 8 commits into from
Aug 2, 2023

Conversation

wugawuga
Copy link
Collaborator

@wugawuga wugawuga commented Aug 1, 2023

Issue

✨ 구현한 기능

  • 리뷰 좋아요, 리뷰 작성 기능에 로그인 기능을 붙였습니다.

📢 논의하고 싶은 내용

2023-08-01 19:40:57.040 WARN 95380 --- [o-auto-1-exec-7] .w.s.m.s.DefaultHandlerExceptionResolver : Resolved [org.springframework.http.converter.HttpMessageNotReadableException: JSON parse error: Cannot construct instance of com.funeat.review.presentation.dto.ReviewFavoriteRequest (although at least one Creator exists): cannot deserialize from Object value (no delegate- or property-based Creator); nested exception is com.fasterxml.jackson.databind.exc.MismatchedInputException: Cannot construct instance of com.funeat.review.presentation.dto.ReviewFavoriteRequest (although at least one Creator exists): cannot deserialize from Object value (no delegate- or property-based Creator) at [Source: (org.springframework.util.StreamUtils$NonClosingInputStream); line: 1, column: 2]]

  • 이러한 오류가 발생합니다. ReviewFavoriteRequest 에서
  • 직렬화 오류라 판단하여 아래와 같이 테스트 통과합니다. 지금은 통과하지 않아요!!
private ReviewFavoriteRequest() {
    this(null);
}

🎸 기타

  • 특이 사항이 있으면 작성합니다.

⏰ 일정

  • 추정 시간 : 1
  • 걸린 시간 : 1

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Unit Test Results

60 tests   60 ✔️  7s ⏱️
32 suites    0 💤
32 files      0

Results for commit 258f165.

♻️ This comment has been updated with latest results.

Copy link
Member

@70825 70825 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

우가 고생하셨어요~ 🥳 :명륜진사우가:

Copy link
Collaborator

@hanueleee hanueleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~

Copy link
Member

@70825 70825 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Collaborator

@Go-Jaecheol Go-Jaecheol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

관련 테스트까지 다 수정하느라 고생 많았어용~!

@wugawuga wugawuga merged commit d1d1afd into develop Aug 2, 2023
3 checks passed
@wugawuga wugawuga deleted the feat/issue-196 branch August 2, 2023 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BE] 리뷰 작성, 좋아요 로그인 붙이기
4 participants