[BE] feat: 상품 랭킹 기능 추가 #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
70825
requested changes
Aug 1, 2023
backend/src/main/java/com/funeat/product/persistence/ProductRepository.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/com/funeat/product/persistence/ProductRepository.java
Outdated
Show resolved
Hide resolved
Comment on lines
38
to
43
| @Query("SELECT new com.funeat.product.dto.ProductReviewCountDto(p, COUNT(r.id)) " | ||
| + "FROM Product p " | ||
| + "LEFT JOIN Review r ON r.product.id = p.id " | ||
| + "WHERE p.averageRating > 3.0 " | ||
| + "GROUP BY p.id") | ||
| List<ProductReviewCountDto> findAllProductsAndReviewCountByAverageRatingGreaterThan3(); |
There was a problem hiding this comment.
저 궁금한 점이 생겼는데, 만약 서비스를 시작하고 나서 누군가의 계략으로 모든 상품의 평균 평점이 3.0 이하로 만들어버리면 리뷰 랭킹 기능은 상품을 보여줄 수 없는건가요??
There was a problem hiding this comment.
저는 개인적으로 평점이 3.0보다 작은 상품들은 랭킹에 노출될 필요가 없다고 생각해요
이 부분은 서비스 정책에 관한 거라 다 같이 얘기해보죠!
backend/src/main/java/com/funeat/product/application/ProductService.java
Outdated
Show resolved
Hide resolved
wugawuga
reviewed
Aug 2, 2023
| + "LEFT JOIN Review r ON r.product.id = p.id " | ||
| + "WHERE p.averageRating > 3.0 " | ||
| + "GROUP BY p.id") | ||
| List<ProductReviewCountDto> findAllProductsAndReviewCountByAverageRatingGreaterThan3(); |
There was a problem hiding this comment.
이미 반환값을 알고 있기때문에 findAllByAverageRatingGreaterThan3 도 괜찮아보여요!!
hanueleee
approved these changes
Aug 2, 2023
| + "LEFT JOIN Review r ON r.product.id = p.id " | ||
| + "WHERE p.averageRating > 3.0 " | ||
| + "GROUP BY p.id") | ||
| List<ProductReviewCountDto> findAllProductsAndReviewCountByAverageRatingGreaterThan3(); |
There was a problem hiding this comment.
ProductRepository의 findAllProductsAndReviewCountByAverageRatingGreaterThan3() 메서드 명 이대로 괜찮은가..!
반환값 이미 알고 있으니까 위 메소드랑 비슷하게 findAllByAverageRatingGreaterThan3 좋을 것 같아요~~
- findAllProductsAndReviewCountByAverageRatingGreaterThan3() -> findAllByAverageRatingGreaterThan3()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
✨ 구현한 기능
상품 랭킹을 조회하는 기능 구현
1.0 ~ 5.0의 AvgRating이 나오게 되므로 그 중간에 있는3.0을 기준으로 기준치 선정3.0보다 큰 상품에 대해서만 랭킹에 포함될 수 있도록 정책 변경📢 논의하고 싶은 내용
ProductRepository의findAllProductsAndReviewCountByAverageRatingGreaterThan3()메서드 명 이대로 괜찮은가..!ProductService에서 stream 한 번만 돌면서 각 Product의 랭킹 점수 구하고, 내림차순 정렬해서 상위 3개에 해당하는 dto 구하도록 했는데 괜찮나용Product도메인에서 랭킹 점수를 구하는 비즈니스 로직을 처리하도록 하기 위해,ProductReviewCountDto에서Product엔티티를 필드로 가지도록 했는데 괜찮은지..!⏰ 일정