Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] feat: CORS 설정 추가 #190

Merged
merged 1 commit into from
Aug 1, 2023
Merged

[BE] feat: CORS 설정 추가 #190

merged 1 commit into from
Aug 1, 2023

Conversation

70825
Copy link
Member

@70825 70825 commented Aug 1, 2023

Issue

✨ 구현한 기능

  • CORS 설정

📢 논의하고 싶은 내용

  • x

🎸 기타

  • x

⏰ 일정

  • 추정 시간 : 0.1
  • 걸린 시간 : 0.01

@70825 70825 self-assigned this Aug 1, 2023
hanueleee
hanueleee approved these changes Aug 1, 2023
View reviewed changes
Copy link
Collaborator

@hanueleee hanueleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Unit Test Results

54 tests   54 ✔️  8s ⏱️
29 suites    0 💤
29 files      0 ❌

Results for commit aecc174.

wugawuga
wugawuga approved these changes Aug 1, 2023
View reviewed changes
Copy link
Collaborator

@wugawuga wugawuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 👍👍

70825
70825 commented Aug 1, 2023
View reviewed changes
Copy link
Member Author

@70825 70825 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

환경 변수로 CORS 설정은 나중에 진행 (찜꽁 코드 참조)

Go-Jaecheol
Go-Jaecheol approved these changes Aug 1, 2023
View reviewed changes
Copy link
Collaborator

@Go-Jaecheol Go-Jaecheol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

추후에 origin 환경 변수로 설정하면 될 것 같습니다.
굿굿!!

@70825 70825 merged commit 827a7d6 into develop Aug 1, 2023
3 checks passed
@70825 70825 deleted the feat/issue-189 branch August 1, 2023 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanueleee hanueleee hanueleee approved these changes

@wugawuga wugawuga wugawuga approved these changes

@Go-Jaecheol Go-Jaecheol Go-Jaecheol approved these changes

Assignees

@70825 70825

Labels
🔒 BE ✨ Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BE] CORS 설정
4 participants
@70825 @Go-Jaecheol @wugawuga @hanueleee