[BE] feat: 전체 태그 목록 조회 기능 추가 #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
70825
approved these changes
Jul 28, 2023
| } | ||
|
|
||
| private void 전체_태그_목록_조회_결과를_검증한다(final ExtractableResponse<Response> response, final List<Tag> tags) { | ||
| final var expectedByType = tags.stream().collect(Collectors.groupingBy(Tag::getTagType)); |
There was a problem hiding this comment.
Collectors.groupingBy()는 처음 보네요
덕분에 새로운 지식 공부했습니다 👍👍
hanueleee
requested changes
Jul 28, 2023
Comment on lines
23
to
37
| public List<TagsResponse> getAllTags() { | ||
| final List<TagsResponse> responses = new ArrayList<>(); | ||
| for (final TagType tagType : TagType.values()) { | ||
| getTagsByTagType(responses, tagType); | ||
| } | ||
| return responses; | ||
| } | ||
|
|
||
| private void getTagsByTagType(final List<TagsResponse> responses, final TagType tagType) { | ||
| final List<TagDto> tags = tagRepository.findTagsByTagType(tagType).stream() | ||
| .map(TagDto::toDto) | ||
| .collect(Collectors.toList()); | ||
| final TagsResponse tagsResponse = TagsResponse.toResponse(tagType.name(), tags); | ||
| responses.add(tagsResponse); | ||
| } |
There was a problem hiding this comment.
Suggested change
| public List<TagsResponse> getAllTags() { | |
| final List<TagsResponse> responses = new ArrayList<>(); | |
| for (final TagType tagType : TagType.values()) { | |
| getTagsByTagType(responses, tagType); | |
| } | |
| return responses; | |
| } | |
| private void getTagsByTagType(final List<TagsResponse> responses, final TagType tagType) { | |
| final List<TagDto> tags = tagRepository.findTagsByTagType(tagType).stream() | |
| .map(TagDto::toDto) | |
| .collect(Collectors.toList()); | |
| final TagsResponse tagsResponse = TagsResponse.toResponse(tagType.name(), tags); | |
| responses.add(tagsResponse); | |
| } | |
| public List<TagsResponse> getAllTags() { | |
| final List<TagsResponse> responses = new ArrayList<>(); | |
| for (final TagType tagType : TagType.values()) { | |
| responses.add(getTagsByTagType(responses, tagType)); | |
| } | |
| return responses; | |
| } | |
| private TagsResponse getTagsByTagType(final TagType tagType) { | |
| final List<TagDto> tags = tagRepository.findTagsByTagType(tagType).stream() | |
| .map(TagDto::toDto) | |
| .collect(Collectors.toList()); | |
| return TagsResponse.toResponse(tagType.name(), tags); | |
| } |
There was a problem hiding this comment.
메소드 이름이 getTagsByTagType니까 TagsResponse를 반환하고 getAllTags에서 add해주는건 어떨까용
wugawuga
approved these changes
Jul 28, 2023
hanueleee
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
✨ 구현한 기능
전체 태그 목록을 조회하는 기능 구현
TASTE,PRICE,ETC📢 논의하고 싶은 내용
DTO 패키지 위치
product.dto에 위치하는데, review 관련 dto 패키지는review.presentation.dto에 위치함service 테스트 관련
성능 관련
⏰ 일정